Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update eslint plugins and fix errors #3637

Merged
merged 17 commits into from
Jul 1, 2024
Merged

update eslint plugins and fix errors #3637

merged 17 commits into from
Jul 1, 2024

Conversation

dimaMachina
Copy link
Collaborator

No description provided.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jul 1, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 5820334

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 11 packages
Name Type
codemirror-graphql Patch
@graphiql/react Patch
graphql-language-service Patch
graphql-language-service-server Patch
monaco-graphql Patch
@graphiql/plugin-code-exporter Patch
@graphiql/plugin-explorer Patch
graphiql Patch
cm6-graphql Patch
graphql-language-service-cli Patch
vscode-graphql Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

dimaMachina
dimaMachina commented Jul 1, 2024
View reviewed changes
packages/graphql-language-service/src/interface/getDefinition.ts
Comment on lines -130 to -132
dependencies.filter(
({ definition }) => definition.name && definition.name.value === typeName,
);
Copy link
Collaborator Author

@dimaMachina dimaMachina Jul 1, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do nothing 😅

@codecov Codecov
Copy link

codecov bot commented Jul 1, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 60.80%. Comparing base (ef57ce5) to head (5820334).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3637      +/-   ##
==========================================
- Coverage   60.81%   60.80%   -0.02%     
==========================================
  Files         120      120              
  Lines        5624     5620       -4     
  Branches     1490     1489       -1     
==========================================
- Hits         3420     3417       -3     
+ Misses       1751     1750       -1     
  Partials      453      453
Files Coverage Δ
...ackages/codemirror-graphql/src/utils/jump-addon.ts 2.85% <100.00%> (ø)
...ages/graphiql-react/src/editor/response-editor.tsx 53.48% <ø> (ø)
...guage-service-server/src/GraphQLLanguageService.ts 70.83% <ø> (ø)
...ql-language-service-server/src/MessageProcessor.ts 74.78% <100.00%> (-0.06%) ⬇️
...graphql-language-service-server/src/parsers/vue.ts 57.69% <ø> (ø)
...ervice/src/interface/getAutocompleteSuggestions.ts 80.41% <100.00%> (ø)
...ql-language-service/src/interface/getDefinition.ts 72.46% <ø> (-0.78%) ⬇️
...raphql-language-service/src/parser/onlineParser.ts 86.99% <ø> (ø)
packages/codemirror-graphql/src/info.ts 0.82% <0.00%> (+<0.01%) ⬆️

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 1, 2024 •
edited
Loading

The latest changes of this PR are available as canary in npm (based on the declared changesets):

[email protected]
[email protected]
[email protected]
@graphiql/[email protected]
@graphiql/[email protected]
@graphiql/[email protected]
[email protected]
[email protected]
[email protected]
[email protected]

@dimaMachina dimaMachina merged commit fdec377 into main Jul 1, 2024
14 checks passed
@dimaMachina dimaMachina deleted the update-eslint-2 branch July 1, 2024 12:30
@acao acao mentioned this pull request Jul 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sec32fun32 Sec32fun32 Sec32fun32 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dimaMachina @Sec32fun32